Commit 06a1e85e authored Feb 28, 2017 by Johannes Berg Committed by Luca Coelho Apr 25, 2017

iwlwifi: remove module loading failure message



When CONFIG_DEBUG_TEST_DRIVER_REMOVE is set, iwlwifi crashes
when the opmode module cannot be loaded, due to completing
the completion before using drv->dev, which can then already
be freed.

Fix this by removing the (fairly useless) message. Moving the
completion later causes a deadlock instead, so that's not an
option.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 53d515ec

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1494,7 +1494,7 @@ static void iwl_req_fw_callback(const struct firmware ucode_raw, void context)
		* or hangs loading.
		*/
		if (load_module) {
		err = request_module("%s", op->name);
		request_module("%s", op->name);
		#ifdef CONFIG_IWLWIFI_OPMODE_MODULAR
		if (err)
		IWL_ERR(drv,