Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 065749ef authored by Oleg Drokin's avatar Oleg Drokin Committed by Greg Kroah-Hartman
Browse files

staging/lustre/fid: seq_client_init/fini don't need to be exported 



In fact they could be static as they are only used inside
this file, so remove EXPORT_SYMBOL and declarations.
Also seq_client_init is always called with srv = NULL, so just
drop this argument.

Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent db65e927

drivers/staging/lustre/lustre/fid/fid_request.c

+18 −21
Original line number Diff line number Diff line
@@ -438,18 +438,29 @@ static int seq_client_debugfs_init(struct lu_client_seq *seq) 
	return rc;

}



int seq_client_init(struct lu_client_seq *seq,

static void seq_client_fini(struct lu_client_seq *seq)

{

	seq_client_debugfs_fini(seq);



	if (seq->lcs_exp) {

		class_export_put(seq->lcs_exp);

		seq->lcs_exp = NULL;

	}



	seq->lcs_srv = NULL;

}



static int seq_client_init(struct lu_client_seq *seq,

			   struct obd_export *exp,

			   enum lu_cli_type type,

		    const char *prefix,

		    struct lu_server_seq *srv)

			   const char *prefix)

{

	int rc;



	LASSERT(seq != NULL);

	LASSERT(prefix != NULL);



	seq->lcs_srv = srv;

	seq->lcs_srv = NULL;

	seq->lcs_type = type;



	mutex_init(&seq->lcs_mutex);
@@ -475,20 +486,6 @@ int seq_client_init(struct lu_client_seq *seq, 
		seq_client_fini(seq);

	return rc;

}

EXPORT_SYMBOL(seq_client_init);



void seq_client_fini(struct lu_client_seq *seq)

{

	seq_client_debugfs_fini(seq);



	if (seq->lcs_exp != NULL) {

		class_export_put(seq->lcs_exp);

		seq->lcs_exp = NULL;

	}



	seq->lcs_srv = NULL;

}

EXPORT_SYMBOL(seq_client_fini);



int client_fid_init(struct obd_device *obd,

		    struct obd_export *exp, enum lu_cli_type type)
@@ -510,7 +507,7 @@ int client_fid_init(struct obd_device *obd, 
	snprintf(prefix, MAX_OBD_NAME + 5, "cli-%s", obd->obd_name);



	/* Init client side sequence-manager */

	rc = seq_client_init(cli->cl_seq, exp, type, prefix, NULL);

	rc = seq_client_init(cli->cl_seq, exp, type, prefix);

	kfree(prefix);

	if (rc)

		goto out_free_seq;

drivers/staging/lustre/lustre/include/lustre_fid.h

+0 −8
Original line number Diff line number Diff line
@@ -426,14 +426,6 @@ struct lu_server_seq { 
};



/* Client methods */

int seq_client_init(struct lu_client_seq *seq,

		    struct obd_export *exp,

		    enum lu_cli_type type,

		    const char *prefix,

		    struct lu_server_seq *srv);



void seq_client_fini(struct lu_client_seq *seq);



void seq_client_flush(struct lu_client_seq *seq);



int seq_client_alloc_fid(const struct lu_env *env, struct lu_client_seq *seq,