Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 051c6764 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

sched: remove prio preference from balance decisions 



Priority looses much of its meaning in a hierarchical context. So don't
use it in balance decisions.

Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 4be9daaa

kernel/sched.c

+3 −9
Original line number Diff line number Diff line
@@ -2896,7 +2896,7 @@ balance_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
	      enum cpu_idle_type idle, int *all_pinned,

	      int *this_best_prio, struct rq_iterator *iterator)

{

	int loops = 0, pulled = 0, pinned = 0, skip_for_load;

	int loops = 0, pulled = 0, pinned = 0;

	struct task_struct *p;

	long rem_load_move = max_load_move;
@@ -2912,14 +2912,8 @@ balance_tasks(struct rq *this_rq, int this_cpu, struct rq *busiest, 
next:

	if (!p || loops++ > sysctl_sched_nr_migrate)

		goto out;

	/*

	 * To help distribute high priority tasks across CPUs we don't

	 * skip a task if it will be the highest priority task (i.e. smallest

	 * prio value) on its new queue regardless of its load weight

	 */

	skip_for_load = (p->se.load.weight >> 1) > rem_load_move +

							 SCHED_LOAD_SCALE_FUZZ;

	if ((skip_for_load && p->prio >= *this_best_prio) ||



	if ((p->se.load.weight >> 1) > rem_load_move ||

	    !can_migrate_task(p, busiest, this_cpu, sd, idle, &pinned)) {

		p = iterator->next(iterator->arg);

		goto next;