Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04eef944 authored by Chandan Uddaraju's avatar Chandan Uddaraju Committed by Aravind Venkateswaran
Browse files

disp: msm: pll: add additional dividers for CPHY support 



Panels supporting Cphy use a specific divider
blocks. Add additional divider blocks for byte
and pixel clock output to support DSI CPHY.

Change-Id: I74b3ee2bdd22ae8fa20567fe837e03915537c4fb
Signed-off-by: default avatarChandan Uddaraju <chandanu@codeaurora.org>
parent 33309d8b

pll/dsi_pll_7nm.c

+260 −51
Original line number Diff line number Diff line
@@ -180,6 +180,7 @@ 
/* Register Offsets from PHY base address */

#define PHY_CMN_CLK_CFG0	0x010

#define PHY_CMN_CLK_CFG1	0x014

#define PHY_CMN_GLBL_CTRL	0x018

#define PHY_CMN_RBUF_CTRL	0x01C

#define PHY_CMN_CTRL_0		0x024

#define PHY_CMN_CTRL_2		0x02C
@@ -279,6 +280,7 @@ struct dsi_pll_7nm { 
	struct mdss_pll_resources *rsc;

	struct dsi_pll_config pll_configuration;

	struct dsi_pll_regs reg_setup;

	bool cphy_enabled;

};



static inline bool dsi_pll_7nm_is_hw_revision_v1(
@@ -454,6 +456,7 @@ static inline int pclk_mux_write_sel(void *context, unsigned int reg, 
{

	int rc = 0;

	struct mdss_pll_resources *rsc = context;

	struct dsi_pll_7nm *pll = rsc->priv;



	rc = mdss_pll_resource_enable(rsc, true);

	if (rc) {
@@ -461,6 +464,59 @@ static inline int pclk_mux_write_sel(void *context, unsigned int reg, 
		return rc;

	}



	if (pll->cphy_enabled)

		WARN_ON("PHY is in CPHY mode. PLL config is incorrect\n");

	rc = pclk_mux_write_sel_sub(rsc, reg, val);

	if (!rc && rsc->slave)

		rc = pclk_mux_write_sel_sub(rsc->slave, reg, val);



	(void)mdss_pll_resource_enable(rsc, false);



	/*

	 * cache the current parent index for cases where parent

	 * is not changing but rate is changing. In that case

	 * clock framework won't call parent_set and hence dsiclk_sel

	 * bit won't be programmed. e.g. dfps update use case.

	 */

	rsc->cached_cfg1 = val;



	return rc;

}



static inline int cphy_pclk_mux_read_sel(void *context, unsigned int reg,

					unsigned int *val)

{

	int rc = 0;

	struct mdss_pll_resources *rsc = context;



	rc = mdss_pll_resource_enable(rsc, true);

	if (rc)

		pr_err("Failed to enable dsi pll resources, rc=%d\n", rc);

	else

		*val = (MDSS_PLL_REG_R(rsc->phy_base, reg) & 0x3);



	(void)mdss_pll_resource_enable(rsc, false);

	return rc;

}



static inline int cphy_pclk_mux_write_sel(void *context, unsigned int reg,

					unsigned int val)

{

	int rc = 0;

	struct mdss_pll_resources *rsc = context;

	struct dsi_pll_7nm *pll = rsc->priv;



	rc = mdss_pll_resource_enable(rsc, true);

	if (rc) {

		pr_err("Failed to enable dsi pll resources, rc=%d\n", rc);

		return rc;

	}



	if (!pll->cphy_enabled)

		WARN_ON("PHY-> not in CPHY mode. PLL config is incorrect\n");

	/* For Cphy configuration, val should always be 3 */

	val = 3;



	rc = pclk_mux_write_sel_sub(rsc, reg, val);

	if (!rc && rsc->slave)

		rc = pclk_mux_write_sel_sub(rsc->slave, reg, val);
@@ -883,6 +939,15 @@ static void dsi_pll_init_val(struct mdss_pll_resources *rsc) 


}



static void dsi_pll_detect_phy_mode(struct dsi_pll_7nm *pll,

			   struct mdss_pll_resources *rsc)

{

	u32 reg_val;



	reg_val = MDSS_PLL_REG_R(rsc->phy_base, PHY_CMN_GLBL_CTRL);

	pll->cphy_enabled = (reg_val & BIT(6)) ? true : false;

}



static void dsi_pll_commit(struct dsi_pll_7nm *pll,

			   struct mdss_pll_resources *rsc)

{
@@ -900,7 +965,8 @@ static void dsi_pll_commit(struct dsi_pll_7nm *pll, 
		       reg->frac_div_start_high);

	MDSS_PLL_REG_W(pll_base, PLL_PLL_LOCKDET_RATE_1, 0x40);

	MDSS_PLL_REG_W(pll_base, PLL_PLL_LOCK_DELAY, 0x06);

	MDSS_PLL_REG_W(pll_base, PLL_CMODE_1, 0x10);

	MDSS_PLL_REG_W(pll_base, PLL_CMODE_1,

				pll->cphy_enabled ? 0x00 : 0x10);

	MDSS_PLL_REG_W(pll_base, PLL_CLOCK_INVERTERS_1,

			reg->pll_clock_inverters);

}
@@ -942,6 +1008,8 @@ static int vco_7nm_set_rate(struct clk_hw *hw, unsigned long rate, 


	dsi_pll_init_val(rsc);



	dsi_pll_detect_phy_mode(pll, rsc);



	dsi_pll_setup_config(pll, rsc);



	dsi_pll_calc_dec_frac(pll, rsc);
@@ -1316,11 +1384,19 @@ static int dsi_pll_enable(struct dsi_pll_vco_clk *vco) 
{

	int rc;

	struct mdss_pll_resources *rsc = vco->priv;

	struct dsi_pll_7nm *pll = rsc->priv;



	dsi_pll_enable_pll_bias(rsc);

	if (rsc->slave)

		dsi_pll_enable_pll_bias(rsc->slave);



	/* For Cphy configuration, pclk_mux is always set to 3 divider */

	if (pll->cphy_enabled) {

		rsc->cached_cfg1 |= 0x3;

		if (rsc->slave)

			rsc->slave->cached_cfg1 |= 0x3;

	}



	phy_reg_update_bits_sub(rsc, PHY_CMN_CLK_CFG1, 0x03, rsc->cached_cfg1);

	if (rsc->slave)

		phy_reg_update_bits_sub(rsc->slave, PHY_CMN_CLK_CFG1,
@@ -1699,6 +1775,11 @@ static struct regmap_bus pclk_src_mux_regmap_bus = { 
	.reg_write = pclk_mux_write_sel,

};



static struct regmap_bus cphy_pclk_src_mux_regmap_bus = {

	.reg_read = cphy_pclk_mux_read_sel,

	.reg_write = cphy_pclk_mux_write_sel,

};



static struct regmap_bus pclk_src_regmap_bus = {

	.reg_write = pixel_clk_set_div,

	.reg_read = pixel_clk_get_div,
@@ -1742,42 +1823,41 @@ static struct regmap_bus mdss_mux_regmap_bus = { 
 *                  |  DIV(1,2,4,8) |

 *                  +-------+-------+

 *                          |

 *                          +-----------------------------+--------+

 *                          +-----------------------------+-------+---------------+

 *                          |                             |       |               |

 *                  +-------v-------+                     |       |               |

 *                  |  bitclk_src   |                                             |

 *                  |  DIV(1..15)   |               Not supported for DPHY        |

 *                  +-------+-------+                                             |

 *                          |                             |       |               |

 *            +-------------v+---------+---------+        |       |               |

 *            |              |         |         |        |       |               |

 *      +-----v-----+  +-----v-----+   |  +------v------+ | +-----v------+  +-----v------+

 *      |byteclk_src|  |byteclk_src|   |  |post_bit_div | | |post_vco_div|  |post_vco_div|

 *      |  DIV(8)   |  |  DIV(7)   |   |  |   DIV (2)   | | |   DIV(4)   |  |  DIV(3.5)  |

 *      +-----+-----+  +-----+-----+   |  +------+------+ | +-----+------+  +------+-----+

 *            |              |         |         |        |       |                |

 *Shadow Path |          CPHY Path     |         |        |       |           +----v

 *     +      |              |         +------+  |        |   +---+           |

 *     +---+  |        +-----+                |  |        |   |               |

 *         |  |        |                    +-v--v----v---v---+      +--------v--------+

 *     +---v--v--------v---+                 \  pclk_src_mux /        \ cphy_pclk_src /

 *      \   byteclk_mux   /                   \             /          \     mux     /

 *       \               /                     +-----+-----+            +-----+-----+

 *        +------+------+                            |      Shadow Path       |

 *               |                                   |           +            |

 *               v                             +-----v------+    |     +------v------+

 *         dsi_byte_clk                        |  pclk_src  |    |     |cphy_pclk_src|

 *                                             | DIV(1..15) |    |     |  DIV(1..15) |

 *                                             +-----+------+    |     +------+------+

 *                                                   |           |            |

 *                  +-------v-------+                     |        |

 *                  |  bitclk_src   |

 *                  |  DIV(1..15)   |                Not supported for DPHY

 *                  +-------+-------+

 *                                                   |           |        CPHY Path

 *                                                   |           |            |

 *                          +----------+---------+        |        |

 *   Shadow Path            |          |         |        |        |

 *       +          +-------v-------+  |  +------v------+ | +------v-------+

 *       |          |  byteclk_src  |  |  |post_bit_div | | |post_vco_div  |

 *       |          |  DIV(8)       |  |  |DIV (2)      | | |DIV(4)        |

 *       |          +-------+-------+  |  +------+------+ | +------+-------+

 *       |                  |          |         |      | |        |

 *       |                  |          |         +------+ |        |

 *       |                  |          +-------------+  | |   +----+

 *       |         +--------+                        |  | |   |

 *       |         |                               +-v--v-v---v------+

 *     +-v---------v----+                           \  pclk_src_mux /

 *     \  byteclk_mux /                              \             /

 *      \            /                                +-----+-----+

 *       +----+-----+                                       |        Shadow Path

 *            |                                             |             +

 *            v                                       +-----v------+      |

 *       dsi_byte_clk                                 |  pclk_src  |      |

 *                                                    | DIV(1..15) |      |

 *                                                    +-----+------+      |

 *                                                          |             |

 *                                                          |             |

 *                                                          +--------+    |

 *                                                                   |    |

 *                                                               +---v----v----+

 *                                                   +-------+   |    +-------+

 *                                                           |   |    |

 *                                                       +---v---v----v------+

 *                                                        \     pclk_mux    /

 *                                                                 \         /

 *                                                                  +---+---+

 *                                                                      |

 *                                                          +------+------+

 *                                                                 |

 *                                                                 v

 *                                                              dsi_pclk
@@ -1993,6 +2073,28 @@ static struct clk_fixed_factor dsi1pll_post_vco_div = { 
	},

};



static struct clk_fixed_factor dsi0pll_post_vco_div3_5 = {

	.div = 7,

	.mult = 2,

	.hw.init = &(struct clk_init_data){

		.name = "dsi0pll_post_vco_div3_5",

		.parent_names = (const char *[]){"dsi0pll_pll_out_div"},

		.num_parents = 1,

		.ops = &clk_fixed_factor_ops,

	},

};



static struct clk_fixed_factor dsi1pll_post_vco_div3_5 = {

	.div = 7,

	.mult = 2,

	.hw.init = &(struct clk_init_data){

		.name = "dsi1pll_post_vco_div3_5",

		.parent_names = (const char *[]){"dsi1pll_pll_out_div"},

		.num_parents = 1,

		.ops = &clk_fixed_factor_ops,

	},

};



static struct clk_fixed_factor dsi1pll_shadow_post_vco_div = {

	.div = 4,

	.mult = 1,
@@ -2040,6 +2142,30 @@ static struct clk_fixed_factor dsi1pll_byteclk_src = { 
	},

};



static struct clk_fixed_factor dsi0pll_cphy_byteclk_src = {

	.div = 7,

	.mult = 1,

	.hw.init = &(struct clk_init_data){

		.name = "dsi0pll_cphy_byteclk_src",

		.parent_names = (const char *[]){"dsi0pll_bitclk_src"},

		.num_parents = 1,

		.flags = CLK_SET_RATE_PARENT,

		.ops = &clk_fixed_factor_ops,

	},

};



static struct clk_fixed_factor dsi1pll_cphy_byteclk_src = {

	.div = 7,

	.mult = 1,

	.hw.init = &(struct clk_init_data){

		.name = "dsi1pll_cphy_byteclk_src",

		.parent_names = (const char *[]){"dsi1pll_bitclk_src"},

		.num_parents = 1,

		.flags = CLK_SET_RATE_PARENT,

		.ops = &clk_fixed_factor_ops,

	},

};



static struct clk_fixed_factor dsi1pll_shadow_byteclk_src = {

	.div = 8,

	.mult = 1,
@@ -2103,8 +2229,9 @@ static struct clk_regmap_mux dsi0pll_byteclk_mux = { 
		.hw.init = &(struct clk_init_data){

			.name = "dsi0_phy_pll_out_byteclk",

			.parent_names = (const char *[]){"dsi0pll_byteclk_src",

				"dsi0pll_shadow_byteclk_src"},

			.num_parents = 2,

				"dsi0pll_shadow_byteclk_src",

				"dsi0pll_cphy_byteclk_src"},

			.num_parents = 3,

			.flags = (CLK_SET_RATE_PARENT |

					CLK_SET_RATE_NO_REPARENT),

			.ops = &clk_regmap_mux_closest_ops,
@@ -2119,8 +2246,9 @@ static struct clk_regmap_mux dsi1pll_byteclk_mux = { 
		.hw.init = &(struct clk_init_data){

			.name = "dsi1_phy_pll_out_byteclk",

			.parent_names = (const char *[]){"dsi1pll_byteclk_src",

				"dsi1pll_shadow_byteclk_src"},

			.num_parents = 2,

				"dsi1pll_shadow_byteclk_src",

				"dsi1pll_cphy_byteclk_src"},

			.num_parents = 3,

			.flags = (CLK_SET_RATE_PARENT |

					CLK_SET_RATE_NO_REPARENT),

			.ops = &clk_regmap_mux_closest_ops,
@@ -2159,6 +2287,21 @@ static struct clk_regmap_mux dsi0pll_shadow_pclk_src_mux = { 
	},

};



static struct clk_regmap_mux dsi0pll_cphy_pclk_src_mux = {

	.reg = PHY_CMN_CLK_CFG1,

	.shift = 0,

	.width = 2,

	.clkr = {

		.hw.init = &(struct clk_init_data){

			.name = "dsi0pll_cphy_pclk_src_mux",

			.parent_names =

				(const char *[]){"dsi0pll_post_vco_div3_5"},

			.num_parents = 1,

			.ops = &clk_regmap_mux_closest_ops,

		},

	},

};



static struct clk_regmap_mux dsi1pll_pclk_src_mux = {

	.reg = PHY_CMN_CLK_CFG1,

	.shift = 0,
@@ -2190,6 +2333,21 @@ static struct clk_regmap_mux dsi1pll_shadow_pclk_src_mux = { 
	},

};



static struct clk_regmap_mux dsi1pll_cphy_pclk_src_mux = {

	.reg = PHY_CMN_CLK_CFG1,

	.shift = 0,

	.width = 2,

	.clkr = {

		.hw.init = &(struct clk_init_data){

			.name = "dsi1pll_cphy_pclk_src_mux",

			.parent_names =

				(const char *[]){"dsi1pll_post_vco_div3_5"},

			.num_parents = 1,

			.ops = &clk_regmap_mux_closest_ops,

		},

	},

};



static struct clk_regmap_div dsi0pll_pclk_src = {

	.shift = 0,

	.width = 4,
@@ -2222,6 +2380,22 @@ static struct clk_regmap_div dsi0pll_shadow_pclk_src = { 
	},

};



static struct clk_regmap_div dsi0pll_cphy_pclk_src = {

	.shift = 0,

	.width = 4,

	.flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,

	.clkr = {

		.hw.init = &(struct clk_init_data){

			.name = "dsi0pll_cphy_pclk_src",

			.parent_names = (const char *[]){

					"dsi0pll_cphy_pclk_src_mux"},

			.num_parents = 1,

			.flags = CLK_SET_RATE_PARENT,

			.ops = &clk_regmap_div_ops,

		},

	},

};



static struct clk_regmap_div dsi1pll_pclk_src = {

	.shift = 0,

	.width = 4,
@@ -2254,6 +2428,22 @@ static struct clk_regmap_div dsi1pll_shadow_pclk_src = { 
	},

};



static struct clk_regmap_div dsi1pll_cphy_pclk_src = {

	.shift = 0,

	.width = 4,

	.flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO,

	.clkr = {

		.hw.init = &(struct clk_init_data){

			.name = "dsi1pll_cphy_pclk_src",

			.parent_names = (const char *[]){

					"dsi1pll_cphy_pclk_src_mux"},

			.num_parents = 1,

			.flags = CLK_SET_RATE_PARENT,

			.ops = &clk_regmap_div_ops,

		},

	},

};



static struct clk_regmap_mux dsi0pll_pclk_mux = {

	.shift = 0,

	.width = 1,
@@ -2261,8 +2451,9 @@ static struct clk_regmap_mux dsi0pll_pclk_mux = { 
		.hw.init = &(struct clk_init_data){

			.name = "dsi0_phy_pll_out_dsiclk",

			.parent_names = (const char *[]){"dsi0pll_pclk_src",

				"dsi0pll_shadow_pclk_src"},

			.num_parents = 2,

				"dsi0pll_shadow_pclk_src",

				"dsi0pll_cphy_pclk_src"},

			.num_parents = 3,

			.flags = (CLK_SET_RATE_PARENT |

					CLK_SET_RATE_NO_REPARENT),

			.ops = &clk_regmap_mux_closest_ops,
@@ -2277,8 +2468,9 @@ static struct clk_regmap_mux dsi1pll_pclk_mux = { 
		.hw.init = &(struct clk_init_data){

			.name = "dsi1_phy_pll_out_dsiclk",

			.parent_names = (const char *[]){"dsi1pll_pclk_src",

				"dsi1pll_shadow_pclk_src"},

			.num_parents = 2,

				"dsi1pll_shadow_pclk_src",

				"dsi1pll_cphy_pclk_src"},

			.num_parents = 3,

			.flags = (CLK_SET_RATE_PARENT |

					CLK_SET_RATE_NO_REPARENT),

			.ops = &clk_regmap_mux_closest_ops,
@@ -2291,12 +2483,16 @@ static struct clk_hw *mdss_dsi_pllcc_7nm[] = { 
	[PLL_OUT_DIV_0_CLK] = &dsi0pll_pll_out_div.clkr.hw,

	[BITCLK_SRC_0_CLK] = &dsi0pll_bitclk_src.clkr.hw,

	[BYTECLK_SRC_0_CLK] = &dsi0pll_byteclk_src.hw,

	[CPHY_BYTECLK_SRC_0_CLK] = &dsi0pll_cphy_byteclk_src.hw,

	[POST_BIT_DIV_0_CLK] = &dsi0pll_post_bit_div.hw,

	[POST_VCO_DIV_0_CLK] = &dsi0pll_post_vco_div.hw,

	[POST_VCO_DIV3_5_0_CLK] = &dsi0pll_post_vco_div3_5.hw,

	[BYTECLK_MUX_0_CLK] = &dsi0pll_byteclk_mux.clkr.hw,

	[PCLK_SRC_MUX_0_CLK] = &dsi0pll_pclk_src_mux.clkr.hw,

	[PCLK_SRC_0_CLK] = &dsi0pll_pclk_src.clkr.hw,

	[PCLK_MUX_0_CLK] = &dsi0pll_pclk_mux.clkr.hw,

	[CPHY_PCLK_SRC_MUX_0_CLK] = &dsi0pll_cphy_pclk_src_mux.clkr.hw,

	[CPHY_PCLK_SRC_0_CLK] = &dsi0pll_cphy_pclk_src.clkr.hw,

	[SHADOW_VCO_CLK_0] = &dsi0pll_shadow_vco_clk.hw,

	[SHADOW_PLL_OUT_DIV_0_CLK] = &dsi0pll_shadow_pll_out_div.clkr.hw,

	[SHADOW_BITCLK_SRC_0_CLK] = &dsi0pll_shadow_bitclk_src.clkr.hw,
@@ -2309,12 +2505,16 @@ static struct clk_hw *mdss_dsi_pllcc_7nm[] = { 
	[PLL_OUT_DIV_1_CLK] = &dsi1pll_pll_out_div.clkr.hw,

	[BITCLK_SRC_1_CLK] = &dsi1pll_bitclk_src.clkr.hw,

	[BYTECLK_SRC_1_CLK] = &dsi1pll_byteclk_src.hw,

	[CPHY_BYTECLK_SRC_1_CLK] = &dsi1pll_cphy_byteclk_src.hw,

	[POST_BIT_DIV_1_CLK] = &dsi1pll_post_bit_div.hw,

	[POST_VCO_DIV_1_CLK] = &dsi1pll_post_vco_div.hw,

	[POST_VCO_DIV3_5_1_CLK] = &dsi1pll_post_vco_div3_5.hw,

	[BYTECLK_MUX_1_CLK] = &dsi1pll_byteclk_mux.clkr.hw,

	[PCLK_SRC_MUX_1_CLK] = &dsi1pll_pclk_src_mux.clkr.hw,

	[PCLK_SRC_1_CLK] = &dsi1pll_pclk_src.clkr.hw,

	[PCLK_MUX_1_CLK] = &dsi1pll_pclk_mux.clkr.hw,

	[CPHY_PCLK_SRC_MUX_1_CLK] = &dsi1pll_cphy_pclk_src_mux.clkr.hw,

	[CPHY_PCLK_SRC_1_CLK] = &dsi1pll_cphy_pclk_src.clkr.hw,

	[SHADOW_VCO_CLK_1] = &dsi1pll_shadow_vco_clk.hw,

	[SHADOW_PLL_OUT_DIV_1_CLK] = &dsi1pll_shadow_pll_out_div.clkr.hw,

	[SHADOW_BITCLK_SRC_1_CLK] = &dsi1pll_shadow_bitclk_src.clkr.hw,
@@ -2379,6 +2579,7 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
		rmap = devm_regmap_init(&pdev->dev, &pclk_src_regmap_bus,

				pll_res, &dsi_pll_7nm_config);

		dsi0pll_pclk_src.clkr.regmap = rmap;

		dsi0pll_cphy_pclk_src.clkr.regmap = rmap;

		dsi0pll_shadow_pclk_src.clkr.regmap = rmap;



		rmap = devm_regmap_init(&pdev->dev, &mdss_mux_regmap_bus,
@@ -2389,6 +2590,10 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
				pll_res, &dsi_pll_7nm_config);

		dsi0pll_pclk_src_mux.clkr.regmap = rmap;

		dsi0pll_shadow_pclk_src_mux.clkr.regmap = rmap;

		rmap = devm_regmap_init(&pdev->dev,

					&cphy_pclk_src_mux_regmap_bus,

					pll_res, &dsi_pll_7nm_config);

		dsi0pll_cphy_pclk_src_mux.clkr.regmap = rmap;



		rmap = devm_regmap_init(&pdev->dev, &mdss_mux_regmap_bus,

				pll_res, &dsi_pll_7nm_config);
@@ -2404,7 +2609,7 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
			dsi0pll_shadow_vco_clk.max_rate = 5000000000;

		}



		for (i = VCO_CLK_0; i <= SHADOW_PCLK_SRC_0_CLK; i++) {

		for (i = VCO_CLK_0; i <= CPHY_PCLK_SRC_0_CLK; i++) {

			clk = devm_clk_register(&pdev->dev,

						mdss_dsi_pllcc_7nm[i]);

			if (IS_ERR(clk)) {
@@ -2433,6 +2638,7 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
		rmap = devm_regmap_init(&pdev->dev, &pclk_src_regmap_bus,

				pll_res, &dsi_pll_7nm_config);

		dsi1pll_pclk_src.clkr.regmap = rmap;

		dsi1pll_cphy_pclk_src.clkr.regmap = rmap;

		dsi1pll_shadow_pclk_src.clkr.regmap = rmap;



		rmap = devm_regmap_init(&pdev->dev, &mdss_mux_regmap_bus,
@@ -2443,11 +2649,14 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
				pll_res, &dsi_pll_7nm_config);

		dsi1pll_pclk_src_mux.clkr.regmap = rmap;

		dsi1pll_shadow_pclk_src_mux.clkr.regmap = rmap;

		rmap = devm_regmap_init(&pdev->dev,

					&cphy_pclk_src_mux_regmap_bus,

					pll_res, &dsi_pll_7nm_config);

		dsi1pll_cphy_pclk_src_mux.clkr.regmap = rmap;



		rmap = devm_regmap_init(&pdev->dev, &mdss_mux_regmap_bus,

				pll_res, &dsi_pll_7nm_config);

		dsi1pll_byteclk_mux.clkr.regmap = rmap;



		dsi1pll_vco_clk.priv = pll_res;

		dsi1pll_shadow_vco_clk.priv = pll_res;
@@ -2458,7 +2667,7 @@ int dsi_pll_clock_register_7nm(struct platform_device *pdev, 
			dsi1pll_shadow_vco_clk.max_rate = 5000000000;

		}



		for (i = VCO_CLK_1; i <= SHADOW_PCLK_SRC_1_CLK; i++) {

		for (i = VCO_CLK_1; i <= CPHY_PCLK_SRC_1_CLK; i++) {

			clk = devm_clk_register(&pdev->dev,

						mdss_dsi_pllcc_7nm[i]);

			if (IS_ERR(clk)) {