Commit 04db4d25 authored Apr 29, 2013 by Joe Perches Committed by Linus Torvalds Apr 29, 2013

checkpatch: complain about executable files



Complain about files with an executable bit set that are not in a scripts/
directory and are not type .pl, .py, .awk, or .sh

Based on an initial patch from Stephen.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a6962d72

scripts/checkpatch.pl

+2 −1

Original line number	Diff line number	Diff line
		@@ -1583,7 +1583,8 @@ sub process {
		# Check for incorrect file permissions
		if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
		my $permhere = $here . "FILE: $realfile\n";
		if ($realfile =~ /(Makefile\|Kconfig\|\.c\|\.h\|\.S\|\.tmpl)$/) {
		if ($realfile !~ m@scripts/@ &&
		$realfile !~ /\.(py\|pl\|awk\|sh)$/) {
		ERROR("EXECUTE_PERMISSIONS",
		"do not set execute permissions for source files\n" . $permhere);
		}