Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04c22714 authored by Anton Blanchard's avatar Anton Blanchard Committed by Thomas Gleixner
Browse files

hrtimer: Rework hrtimer_nanosleep to make sys_compat_nanosleep easier 



Pull the copy_to_user out of hrtimer_nanosleep and into the callers
(common_nsleep, sys_nanosleep) in preparation for converting
compat_sys_nanosleep to use hrtimers.

Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent d85714d8

include/linux/hrtimer.h

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ hrtimer_forward(struct hrtimer *timer, ktime_t now, ktime_t interval); 


/* Precise sleep: */

extern long hrtimer_nanosleep(struct timespec *rqtp,

			      struct timespec __user *rmtp,

			      struct timespec *rmtp,

			      const enum hrtimer_mode mode,

			      const clockid_t clockid);

extern long hrtimer_nanosleep_restart(struct restart_block *restart_block);

kernel/hrtimer.c

+16 −13
Original line number Diff line number Diff line
@@ -1286,8 +1286,7 @@ static int __sched do_nanosleep(struct hrtimer_sleeper *t, enum hrtimer_mode mod 
long __sched hrtimer_nanosleep_restart(struct restart_block *restart)

{

	struct hrtimer_sleeper t;

	struct timespec __user *rmtp;

	struct timespec tu;

	struct timespec *rmtp;

	ktime_t time;



	restart->fn = do_no_restart_syscall;
@@ -1298,14 +1297,12 @@ long __sched hrtimer_nanosleep_restart(struct restart_block *restart) 
	if (do_nanosleep(&t, HRTIMER_MODE_ABS))

		return 0;



	rmtp = (struct timespec __user *) restart->arg1;

	rmtp = (struct timespec *)restart->arg1;

	if (rmtp) {

		time = ktime_sub(t.timer.expires, t.timer.base->get_time());

		if (time.tv64 <= 0)

			return 0;

		tu = ktime_to_timespec(time);

		if (copy_to_user(rmtp, &tu, sizeof(tu)))

			return -EFAULT;

		*rmtp = ktime_to_timespec(time);

	}



	restart->fn = hrtimer_nanosleep_restart;
@@ -1314,12 +1311,11 @@ long __sched hrtimer_nanosleep_restart(struct restart_block *restart) 
	return -ERESTART_RESTARTBLOCK;

}



long hrtimer_nanosleep(struct timespec *rqtp, struct timespec __user *rmtp,

long hrtimer_nanosleep(struct timespec *rqtp, struct timespec *rmtp,

		       const enum hrtimer_mode mode, const clockid_t clockid)

{

	struct restart_block *restart;

	struct hrtimer_sleeper t;

	struct timespec tu;

	ktime_t rem;



	hrtimer_init(&t.timer, clockid, mode);
@@ -1335,9 +1331,7 @@ long hrtimer_nanosleep(struct timespec *rqtp, struct timespec __user *rmtp, 
		rem = ktime_sub(t.timer.expires, t.timer.base->get_time());

		if (rem.tv64 <= 0)

			return 0;

		tu = ktime_to_timespec(rem);

		if (copy_to_user(rmtp, &tu, sizeof(tu)))

			return -EFAULT;

		*rmtp = ktime_to_timespec(rem);

	}



	restart = &current_thread_info()->restart_block;
@@ -1353,7 +1347,8 @@ long hrtimer_nanosleep(struct timespec *rqtp, struct timespec __user *rmtp, 
asmlinkage long

sys_nanosleep(struct timespec __user *rqtp, struct timespec __user *rmtp)

{

	struct timespec tu;

	struct timespec tu, rmt;

	int ret;



	if (copy_from_user(&tu, rqtp, sizeof(tu)))

		return -EFAULT;
@@ -1361,7 +1356,15 @@ sys_nanosleep(struct timespec __user *rqtp, struct timespec __user *rmtp) 
	if (!timespec_valid(&tu))

		return -EINVAL;



	return hrtimer_nanosleep(&tu, rmtp, HRTIMER_MODE_REL, CLOCK_MONOTONIC);

	ret = hrtimer_nanosleep(&tu, rmtp ? &rmt : NULL, HRTIMER_MODE_REL,

				CLOCK_MONOTONIC);



	if (ret && rmtp) {

		if (copy_to_user(rmtp, &rmt, sizeof(*rmtp)))

			return -EFAULT;

	}



	return ret;

}



/*

kernel/posix-timers.c

+14 −3
Original line number Diff line number Diff line
@@ -981,9 +981,20 @@ sys_clock_getres(const clockid_t which_clock, struct timespec __user *tp) 
static int common_nsleep(const clockid_t which_clock, int flags,

			 struct timespec *tsave, struct timespec __user *rmtp)

{

	return hrtimer_nanosleep(tsave, rmtp, flags & TIMER_ABSTIME ?

	struct timespec rmt;

	int ret;



	ret = hrtimer_nanosleep(tsave, rmtp ? &rmt : NULL,

				flags & TIMER_ABSTIME ?

				HRTIMER_MODE_ABS : HRTIMER_MODE_REL,

				which_clock);



	if (ret && rmtp) {

		if (copy_to_user(rmtp, &rmt, sizeof(*rmtp)))

			return -EFAULT;

	}



	return ret;

}



asmlinkage long