Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 045288e8 authored by Jyoti Kumari's avatar Jyoti Kumari
Browse files

qcacld-3.0: Avoid excessive kmsg log in roam stats event handler 

Sometimes firmware sends WMI_ROAM_STATS_EVENTID repeatedly with
wrong TLV. This causes event extraction failure at the event
handler and continuous error logs are written to kmsg.

Replace error prints in wma_roam_stats_event_handler() with
debug level prints.

Change-Id: Iba03e22239281a921cfcab4a37eba2894ec006f4
CRs-Fixed: 2826127
parent b8754961

core/wma/src/wma_scan_roam.c

+10 −11
Original line number Diff line number Diff line
@@ -3839,7 +3839,7 @@ int wma_roam_stats_event_handler(WMA_HANDLE handle, uint8_t *event, 
					wma->wmi_handle, event,

					&roam_info->data_11kv, 0, 0);

		if (QDF_IS_STATUS_ERROR(status)) {

			WMA_LOGE("%s: Roam 11kv stats extract failed vdev %d",

			wma_debug("%s: Roam 11kv stats extract failed vdev %d",

				  __func__, vdev_id);

			qdf_mem_free(roam_info);

			goto err;
@@ -3865,8 +3865,8 @@ int wma_roam_stats_event_handler(WMA_HANDLE handle, uint8_t *event, 
						wma->wmi_handle, event,

						&roam_info->trigger, i);

		if (QDF_IS_STATUS_ERROR(status)) {

			WMA_LOGE("%s: Extract roam trigger stats failed vdev%d",

				 __func__, vdev_id);

			wma_debug("%s: Extract roam trigger stats failed vdev %d at %d iteration",

				  __func__, vdev_id, i);

			qdf_mem_free(roam_info);

			return -EINVAL;

		}
@@ -3877,8 +3877,8 @@ int wma_roam_stats_event_handler(WMA_HANDLE handle, uint8_t *event, 
							&roam_info->scan, i,

							num_chan, num_ap);

		if (QDF_IS_STATUS_ERROR(status)) {

			WMA_LOGE("%s: Roam scan stats extract failed vdev %d",

				 __func__, vdev_id);

			wma_debug("%s: Roam scan stats extract failed vdev %d at %d iteration",

				  __func__, vdev_id, i);

			qdf_mem_free(roam_info);

			return -EINVAL;

		}
@@ -3890,19 +3890,18 @@ int wma_roam_stats_event_handler(WMA_HANDLE handle, uint8_t *event, 
							wma->wmi_handle, event,

							&roam_info->result, i);

		if (QDF_IS_STATUS_ERROR(status)) {

			WMA_LOGE("%s: Roam result stats extract failed vdev %d",

				 __func__, vdev_id);

			wma_debug("%s: Roam result stats extract failed vdev %d at %d iteration",

				  __func__, vdev_id, i);

			qdf_mem_free(roam_info);

			return -EINVAL;

		}



		/* BTM req/resp or Neighbor report/response info */

		status = wmi_unified_extract_roam_11kv_stats(

				wma->wmi_handle, event,

				&roam_info->data_11kv, i, num_rpt);

		if (QDF_IS_STATUS_ERROR(status)) {

			WMA_LOGE("%s: Roam 11kv stats extract failed vdev %d",

				 __func__, vdev_id);

			wma_debug("%s: Roam 11kv stats extract failed vdev %d at %d iteration",

				  __func__, vdev_id, i);

			qdf_mem_free(roam_info);

			return -EINVAL;

		}