Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0418dae1 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Fail the truncate() if the lock/open stateid is invalid 



If the open stateid could not be recovered, or the file locks were lost,
then we should fail the truncate() operation altogether.

Reported-by: default avatarAndy Adamson <andros@netapp.com>
Link: http://lkml.kernel.org/r/1393954269-3974-1-git-send-email-andros@netapp.com


Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
parent 869a9d37

fs/nfs/nfs4proc.c

+6 −3
Original line number Diff line number Diff line
@@ -2398,13 +2398,16 @@ static int _nfs4_do_setattr(struct inode *inode, struct rpc_cred *cred, 


	if (nfs4_copy_delegation_stateid(&arg.stateid, inode, fmode)) {

		/* Use that stateid */

	} else if (truncate && state != NULL && nfs4_valid_open_stateid(state)) {

	} else if (truncate && state != NULL) {

		struct nfs_lockowner lockowner = {

			.l_owner = current->files,

			.l_pid = current->tgid,

		};

		nfs4_select_rw_stateid(&arg.stateid, state, FMODE_WRITE,

				&lockowner);

		if (!nfs4_valid_open_stateid(state))

			return -EBADF;

		if (nfs4_select_rw_stateid(&arg.stateid, state, FMODE_WRITE,

				&lockowner) == -EIO)

			return -EBADF;

	} else

		nfs4_stateid_copy(&arg.stateid, &zero_stateid);