Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03a6f290 authored by Gary R Hook's avatar Gary R Hook Committed by Herbert Xu
Browse files

crypto: ccp - fix lock acquisition code 



This patch simplifies an unneeded read-write lock.

Signed-off-by: default avatarGary R Hook <gary.hook@amd.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d1558f4e

drivers/crypto/ccp/ccp-dev.c

+3 −3
Original line number Diff line number Diff line
@@ -53,7 +53,7 @@ static DEFINE_RWLOCK(ccp_unit_lock); 
static LIST_HEAD(ccp_units);



/* Round-robin counter */

static DEFINE_RWLOCK(ccp_rr_lock);

static DEFINE_SPINLOCK(ccp_rr_lock);

static struct ccp_device *ccp_rr;



/* Ever-increasing value to produce unique unit numbers */
@@ -128,14 +128,14 @@ static struct ccp_device *ccp_get_device(void) 
	 */

	read_lock_irqsave(&ccp_unit_lock, flags);

	if (!list_empty(&ccp_units)) {

		write_lock_irqsave(&ccp_rr_lock, flags);

		spin_lock(&ccp_rr_lock);

		dp = ccp_rr;

		if (list_is_last(&ccp_rr->entry, &ccp_units))

			ccp_rr = list_first_entry(&ccp_units, struct ccp_device,

						  entry);

		else

			ccp_rr = list_next_entry(ccp_rr, entry);

		write_unlock_irqrestore(&ccp_rr_lock, flags);

		spin_unlock(&ccp_rr_lock);

	}

	read_unlock_irqrestore(&ccp_unit_lock, flags);