Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02c91ece authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

net: mvpp2: Use kmalloc_array() in mvpp2_txq_init() 



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f95936cc

drivers/net/ethernet/marvell/mvpp2.c

+3 −3
Original line number Diff line number Diff line
@@ -5083,8 +5083,8 @@ static int mvpp2_txq_init(struct mvpp2_port *port, 
	for_each_present_cpu(cpu) {

		txq_pcpu = per_cpu_ptr(txq->pcpu, cpu);

		txq_pcpu->size = txq->size;

		txq_pcpu->buffs = kmalloc(txq_pcpu->size *

					  sizeof(struct mvpp2_txq_pcpu_buf),

		txq_pcpu->buffs = kmalloc_array(txq_pcpu->size,

						sizeof(*txq_pcpu->buffs),

						GFP_KERNEL);

		if (!txq_pcpu->buffs)

			goto error;