Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02c5e844 authored by WANG Cong's avatar WANG Cong Committed by David S. Miller
Browse files

net_sched: fix errno in tcindex_set_parms() 



When kmemdup() fails, we should return -ENOMEM.

Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Acked-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c01035f1

net/sched/cls_tcindex.c

+2 −3
Original line number Diff line number Diff line
@@ -237,15 +237,14 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base, 
	if (err < 0)

		return err;



	err = -ENOMEM;

	/* tcindex_data attributes must look atomic to classifier/lookup so

	 * allocate new tcindex data and RCU assign it onto root. Keeping

	 * perfect hash and hash pointers from old data.

	 */

	cp = kzalloc(sizeof(*cp), GFP_KERNEL);

	if (!cp) {

		err = -ENOMEM;

	if (!cp)

		goto errout;

	}



	cp->mask = p->mask;

	cp->shift = p->shift;