Commit 02a2385f authored Mar 14, 2018 by Nicolas Dichtel Committed by David S. Miller Mar 16, 2018

netlink: avoid a double skb free in genlmsg_mcast()

nlmsg_multicast() consumes always the skb, thus the original skb must be
freed only when this function is called with a clone.

Fixes: cb9f7a9a ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()")
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4609adc2

net/netlink/genetlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1106,7 +1106,7 @@ static int genlmsg_mcast(struct sk_buff *skb, u32 portid, unsigned long group,
		if (!err)
		delivered = true;
		else if (err != -ESRCH)
		goto error;
		return err;
		return delivered ? 0 : -ESRCH;
		error:
		kfree_skb(skb);