Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 028a9e5c authored by Jeffy Chen's avatar Jeffy Chen Committed by Heiko Stuebner
Browse files

drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind 



In bind the clk_prepare_enable of the HDMI pclk is called before adding the
i2c_adapter. So it should be the other way around in unbind, first remove
the i2c_adapter and then call the clk_disable_unprepare.

Fixes: 412d4ae6 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Signed-off-by: default avatarJeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: default avatarThierry Escande <thierry.escande@collabora.com>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20180302175757.28192-4-enric.balletbo@collabora.com
parent 61b5ff96

drivers/gpu/drm/rockchip/inno_hdmi.c

+1 −1
Original line number Diff line number Diff line
@@ -906,8 +906,8 @@ static void inno_hdmi_unbind(struct device *dev, struct device *master, 
	hdmi->connector.funcs->destroy(&hdmi->connector);

	hdmi->encoder.funcs->destroy(&hdmi->encoder);



	clk_disable_unprepare(hdmi->pclk);

	i2c_put_adapter(hdmi->ddc);

	clk_disable_unprepare(hdmi->pclk);

}



static const struct component_ops inno_hdmi_ops = {