Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 028635d6 authored by Mathieu OTHACEHE's avatar Mathieu OTHACEHE Committed by Johan Hovold
Browse files

USB: mxu11x0: fix memory leak on usb_serial private data 



On nominal execution, private data allocated on port_probe and attach
are never freed. Add port_remove and release callbacks to free them
respectively.

Signed-off-by: default avatarMathieu OTHACEHE <m.othacehe@gmail.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent e03cdf22

drivers/usb/serial/mxu11x0.c

+20 −0
Original line number Diff line number Diff line
@@ -368,6 +368,16 @@ static int mxu1_port_probe(struct usb_serial_port *port) 
	return 0;

}



static int mxu1_port_remove(struct usb_serial_port *port)

{

	struct mxu1_port *mxport;



	mxport = usb_get_serial_port_data(port);

	kfree(mxport);



	return 0;

}



static int mxu1_startup(struct usb_serial *serial)

{

	struct mxu1_device *mxdev;
@@ -427,6 +437,14 @@ static int mxu1_startup(struct usb_serial *serial) 
	return err;

}



static void mxu1_release(struct usb_serial *serial)

{

	struct mxu1_device *mxdev;



	mxdev = usb_get_serial_data(serial);

	kfree(mxdev);

}



static int mxu1_write_byte(struct usb_serial_port *port, u32 addr,

			   u8 mask, u8 byte)

{
@@ -957,7 +975,9 @@ static struct usb_serial_driver mxu11x0_device = { 
	.id_table		= mxu1_idtable,

	.num_ports		= 1,

	.port_probe             = mxu1_port_probe,

	.port_remove            = mxu1_port_remove,

	.attach			= mxu1_startup,

	.release                = mxu1_release,

	.open			= mxu1_open,

	.close			= mxu1_close,

	.ioctl			= mxu1_ioctl,