Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 027a6976 authored by Peter Chen's avatar Peter Chen Committed by Eric Anholt
Browse files

gpu: drm: vc4_hdmi: add missing of_node_put after calling of_parse_phandle 



of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: default avatarPeter Chen <peter.chen@nxp.com>
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
parent 93977767

drivers/gpu/drm/vc4/vc4_hdmi.c

+7 −6
Original line number Diff line number Diff line
@@ -465,12 +465,6 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) 
	if (IS_ERR(hdmi->hd_regs))

		return PTR_ERR(hdmi->hd_regs);



	ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);

	if (!ddc_node) {

		DRM_ERROR("Failed to find ddc node in device tree\n");

		return -ENODEV;

	}



	hdmi->pixel_clock = devm_clk_get(dev, "pixel");

	if (IS_ERR(hdmi->pixel_clock)) {

		DRM_ERROR("Failed to get pixel clock\n");
@@ -482,7 +476,14 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) 
		return PTR_ERR(hdmi->hsm_clock);

	}



	ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);

	if (!ddc_node) {

		DRM_ERROR("Failed to find ddc node in device tree\n");

		return -ENODEV;

	}



	hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);

	of_node_put(ddc_node);

	if (!hdmi->ddc) {

		DRM_DEBUG("Failed to get ddc i2c adapter by node\n");

		return -EPROBE_DEFER;