Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 024cfa59 authored by Mathias Nyman's avatar Mathias Nyman Committed by Greg Kroah-Hartman
Browse files

usb: musb_debugfs: don't use the struct file private_data field with seq_files 



seq_files use the private_data field of a file struct for storing a seq_file structure,
data should be stored in seq_file's own private field (e.g. file->private_data->private)
Otherwise seq_release() will free the private data when the file is closed.

Signed-off-by: default avatarMathias Nyman <mathias.nyman@nokia.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2422084a

drivers/usb/musb/musb_debugfs.c

+2 −3
Original line number Diff line number Diff line
@@ -195,15 +195,14 @@ static const struct file_operations musb_regdump_fops = { 


static int musb_test_mode_open(struct inode *inode, struct file *file)

{

	file->private_data = inode->i_private;



	return single_open(file, musb_test_mode_show, inode->i_private);

}



static ssize_t musb_test_mode_write(struct file *file,

		const char __user *ubuf, size_t count, loff_t *ppos)

{

	struct musb		*musb = file->private_data;

	struct seq_file		*s = file->private_data;

	struct musb		*musb = s->private;

	u8			test = 0;

	char			buf[18];