Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 022ab148 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Linus Walleij
Browse files

pinctrl: Declare operation structures as const 



The pinconf, pinctrl and pinmux operation structures hold function
pointers that are never modified. Declare them as const.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a72149e8

drivers/pinctrl/devicetree.c

+2 −2
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ static void dt_free_map(struct pinctrl_dev *pctldev, 
		     struct pinctrl_map *map, unsigned num_maps)

{

	if (pctldev) {

		struct pinctrl_ops *ops = pctldev->desc->pctlops;

		const struct pinctrl_ops *ops = pctldev->desc->pctlops;

		ops->dt_free_map(pctldev, map, num_maps);

	} else {

		/* There is no pctldev for PIN_MAP_TYPE_DUMMY_STATE */
@@ -122,7 +122,7 @@ static int dt_to_map_one_config(struct pinctrl *p, const char *statename, 
{

	struct device_node *np_pctldev;

	struct pinctrl_dev *pctldev;

	struct pinctrl_ops *ops;

	const struct pinctrl_ops *ops;

	int ret;

	struct pinctrl_map *map;

	unsigned num_maps;

drivers/pinctrl/mvebu/pinctrl-mvebu.c

+3 −3
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ static void mvebu_pinconf_group_dbg_show(struct pinctrl_dev *pctldev, 
	return;

}



static struct pinconf_ops mvebu_pinconf_ops = {

static const struct pinconf_ops mvebu_pinconf_ops = {

	.pin_config_group_get = mvebu_pinconf_group_get,

	.pin_config_group_set = mvebu_pinconf_group_set,

	.pin_config_group_dbg_show = mvebu_pinconf_group_dbg_show,
@@ -369,7 +369,7 @@ static int mvebu_pinmux_gpio_set_direction(struct pinctrl_dev *pctldev, 
	return -ENOTSUPP;

}



static struct pinmux_ops mvebu_pinmux_ops = {

static const struct pinmux_ops mvebu_pinmux_ops = {

	.get_functions_count = mvebu_pinmux_get_funcs_count,

	.get_function_name = mvebu_pinmux_get_func_name,

	.get_function_groups = mvebu_pinmux_get_groups,
@@ -470,7 +470,7 @@ static void mvebu_pinctrl_dt_free_map(struct pinctrl_dev *pctldev, 
	kfree(map);

}



static struct pinctrl_ops mvebu_pinctrl_ops = {

static const struct pinctrl_ops mvebu_pinctrl_ops = {

	.get_groups_count = mvebu_pinctrl_get_groups_count,

	.get_group_name = mvebu_pinctrl_get_group_name,

	.get_group_pins = mvebu_pinctrl_get_group_pins,

drivers/pinctrl/pinconf.c

+1 −1
Original line number Diff line number Diff line
@@ -670,7 +670,7 @@ static int pinconf_dbg_config_print(struct seq_file *s, void *d) 
	struct pinctrl_maps *maps_node;

	struct pinctrl_map const *map;

	struct pinctrl_dev *pctldev = NULL;

	struct pinconf_ops *confops = NULL;

	const struct pinconf_ops *confops = NULL;

	int i, j;

	bool found = false;

drivers/pinctrl/pinctrl-abx500.c

+3 −3
Original line number Diff line number Diff line
@@ -656,7 +656,7 @@ static void abx500_gpio_disable_free(struct pinctrl_dev *pctldev, 
{

}



static struct pinmux_ops abx500_pinmux_ops = {

static const struct pinmux_ops abx500_pinmux_ops = {

	.get_functions_count = abx500_pmx_get_funcs_cnt,

	.get_function_name = abx500_pmx_get_func_name,

	.get_function_groups = abx500_pmx_get_func_groups,
@@ -704,7 +704,7 @@ static void abx500_pin_dbg_show(struct pinctrl_dev *pctldev, 
				 chip->base + offset - 1);

}



static struct pinctrl_ops abx500_pinctrl_ops = {

static const struct pinctrl_ops abx500_pinctrl_ops = {

	.get_groups_count = abx500_get_groups_cnt,

	.get_group_name = abx500_get_group_name,

	.get_group_pins = abx500_get_group_pins,
@@ -778,7 +778,7 @@ int abx500_pin_config_set(struct pinctrl_dev *pctldev, 
	return ret;

}



static struct pinconf_ops abx500_pinconf_ops = {

static const struct pinconf_ops abx500_pinconf_ops = {

	.pin_config_get = abx500_pin_config_get,

	.pin_config_set = abx500_pin_config_set,

};

drivers/pinctrl/pinctrl-at91.c

+3 −3
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ static void at91_dt_free_map(struct pinctrl_dev *pctldev, 
{

}



static struct pinctrl_ops at91_pctrl_ops = {

static const struct pinctrl_ops at91_pctrl_ops = {

	.get_groups_count	= at91_get_groups_count,

	.get_group_name		= at91_get_group_name,

	.get_group_pins		= at91_get_group_pins,
@@ -696,7 +696,7 @@ static void at91_gpio_disable_free(struct pinctrl_dev *pctldev, 
	/* Set the pin to some default state, GPIO is usually default */

}



static struct pinmux_ops at91_pmx_ops = {

static const struct pinmux_ops at91_pmx_ops = {

	.get_functions_count	= at91_pmx_get_funcs_count,

	.get_function_name	= at91_pmx_get_func_name,

	.get_function_groups	= at91_pmx_get_groups,
@@ -776,7 +776,7 @@ static void at91_pinconf_group_dbg_show(struct pinctrl_dev *pctldev, 
{

}



static struct pinconf_ops at91_pinconf_ops = {

static const struct pinconf_ops at91_pinconf_ops = {

	.pin_config_get			= at91_pinconf_get,

	.pin_config_set			= at91_pinconf_set,

	.pin_config_dbg_show		= at91_pinconf_dbg_show,