Commit 0218c766 authored Jun 22, 2018 by Zhenzhong Duan Committed by Thomas Gleixner Jun 22, 2018

x86/microcode/intel: Fix memleak in save_microcode_patch()



Free useless ucode_patch entry when it's replaced.

[ bp: Drop the memfree_patch() two-liner. ]

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Srinivas REDDY Eeda <srinivas.eeda@oracle.com>
Link: http://lkml.kernel.org/r/888102f0-fd22-459d-b090-a1bd8a00cb2b@default

parent d7609f42

arch/x86/kernel/cpu/microcode/intel.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -190,8 +190,11 @@ static void save_microcode_patch(void *data, unsigned int size)
		p = memdup_patch(data, size);
		if (!p)
		pr_err("Error allocating buffer %p\n", data);
		else
		else {
		list_replace(&iter->plist, &p->plist);
		kfree(iter->data);
		kfree(iter);
		}
		}
		}