Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 020d30f1 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Greg Kroah-Hartman
Browse files

kobject: fix memory leak in kobject_set_name_vargs 



If the call to kvasprintf fails then the old name of the object will be leaked,
this patch fixes the bug by restoring the old name before returning ENOMEM.

Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 21d71662

lib/kobject.c

+3 −1
Original line number Diff line number Diff line
@@ -265,8 +265,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt, 
		return 0;



	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);

	if (!kobj->name)

	if (!kobj->name) {

		kobj->name = old_name;

		return -ENOMEM;

	}



	/* ewww... some of these buggers have '/' in the name ... */

	while ((s = strchr(kobj->name, '/')))