Commit 01e866bf authored Jul 09, 2018 by Vlad Buslov Committed by David S. Miller Jul 11, 2018

net: sched: act_ife: fix memory leak in ife init



Free params if tcf_idr_check_alloc() returned error.

Fixes: 0190c1d4 ("net: sched: atomically check-allocate action")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8dce04f1

net/sched/act_ife.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -485,8 +485,10 @@ static int tcf_ife_init(struct net net, struct nlattr nla,
		return -ENOMEM;

		err = tcf_idr_check_alloc(tn, &parm->index, a, bind);
		if (err < 0)
		if (err < 0) {
		kfree(p);
		return err;
		}
		exists = err;
		if (exists && bind) {
		kfree(p);