Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 01812ba3 authored by Himanshu Jha's avatar Himanshu Jha Committed by Greg Kroah-Hartman
Browse files

usb: isp1760: Use kasprintf 



Use kasprintf instead of combination of kmalloc and sprintf and
therefore avoid unnecessary computation of string length.
Also, remove the useless local variable.

Signed-off-by: default avatarHimanshu Jha <himanshujha199640@gmail.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 161c3bc3

drivers/usb/isp1760/isp1760-udc.c

+1 −5
Original line number Diff line number Diff line
@@ -1441,7 +1441,6 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq, 
			 unsigned long irqflags)

{

	struct isp1760_udc *udc = &isp->udc;

	const char *devname;

	int ret;



	udc->irq = -1;
@@ -1455,13 +1454,10 @@ int isp1760_udc_register(struct isp1760_device *isp, int irq, 
	if (ret < 0)

		return ret;



	devname = dev_name(isp->dev);

	udc->irqname = kmalloc(strlen(devname) + 7, GFP_KERNEL);

	udc->irqname = kasprintf(GFP_KERNEL, "%s (udc)", dev_name(isp->dev));

	if (!udc->irqname)

		return -ENOMEM;



	sprintf(udc->irqname, "%s (udc)", devname);



	ret = request_irq(irq, isp1760_udc_irq, IRQF_SHARED | irqflags,

			  udc->irqname, udc);

	if (ret < 0)