Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 011db815 authored by Micah Gruber's avatar Micah Gruber Committed by Greg Kroah-Hartman
Browse files

USB: Remove unneeded pointer intf from speedtch_upload_firmware() 



This trivial patch removes the unneeded pointer intf returned from
usb_ifnum_to_if(), which is never used. The check for NULL can be simply done
by if (!usb_ifnum_to_if(usb_dev, 2)).

Signed-off-by: default avatarMicah Gruber <micah.gruber@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 782e3b3b

drivers/usb/atm/speedtch.c

+1 −2
Original line number Diff line number Diff line
@@ -251,7 +251,6 @@ static int speedtch_upload_firmware(struct speedtch_instance_data *instance, 
{

	unsigned char *buffer;

	struct usbatm_data *usbatm = instance->usbatm;

	struct usb_interface *intf;

	struct usb_device *usb_dev = usbatm->usb_dev;

	int actual_length;

	int ret = 0;
@@ -265,7 +264,7 @@ static int speedtch_upload_firmware(struct speedtch_instance_data *instance, 
		goto out;

	}



	if (!(intf = usb_ifnum_to_if(usb_dev, 2))) {

	if (!usb_ifnum_to_if(usb_dev, 2)) {

		ret = -ENODEV;

		usb_dbg(usbatm, "%s: interface not found!\n", __func__);

		goto out_free;