Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0114bf7e authored by Rama Aparna Mallavarapu's avatar Rama Aparna Mallavarapu
Browse files

PM / devfreq: devbw: Switch to OPP APIs 



OPP framework exposes a set of functions that could be used to fetch
the list of supported bandwidth values from DT and to query the list
for an appropriate value while honoring requests from
governors/clients.
Use OPP table APIs and get rid of frequency table logic to make the
code more concise and upstream friendly.

Change-Id: I120ae7230bdbfaaa9523263c65a8b84470583071
Signed-off-by: default avatarRohit Gupta <rohgup@codeaurora.org>
Signed-off-by: default avatarRama Aparna Mallavarapu <aparnam@codeaurora.org>
parent 501a7a1c

drivers/devfreq/devfreq_devbw.c

+10 −47
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2013-2014, 2019, The Linux Foundation. All rights reserved.

 * Copyright (c) 2013-2014, 2018, 2019, The Linux Foundation. All rights reserved.

 */



#define pr_fmt(fmt) "devbw: " fmt
@@ -70,33 +70,15 @@ static int set_bw(struct device *dev, int new_ib, int new_ab) 
	return ret;

}



static void find_freq(struct devfreq_dev_profile *p, unsigned long *freq,

			u32 flags)

{

	int i;

	unsigned long atmost, atleast, f;



	atmost = p->freq_table[0];

	atleast = p->freq_table[p->max_state-1];

	for (i = 0; i < p->max_state; i++) {

		f = p->freq_table[i];

		if (f <= *freq)

			atmost = max(f, atmost);

		if (f >= *freq)

			atleast = min(f, atleast);

	}



	if (flags & DEVFREQ_FLAG_LEAST_UPPER_BOUND)

		*freq = atmost;

	else

		*freq = atleast;

}



static int devbw_target(struct device *dev, unsigned long *freq, u32 flags)

{

	struct dev_data *d = dev_get_drvdata(dev);

	struct dev_pm_opp *opp;



	opp = devfreq_recommended_opp(dev, freq, flags);

	if (!IS_ERR(opp))

		dev_pm_opp_put(opp);



	find_freq(&d->dp, freq, flags);

	return set_bw(dev, *freq, d->gov_ab);

}
@@ -110,14 +92,13 @@ static int devbw_get_dev_status(struct device *dev, 
}



#define PROP_PORTS "qcom,src-dst-ports"

#define PROP_TBL "qcom,bw-tbl"

#define PROP_ACTIVE "qcom,active-only"



int devfreq_add_devbw(struct device *dev)

{

	struct dev_data *d;

	struct devfreq_dev_profile *p;

	u32 *data, ports[MAX_PATHS * 2];

	u32 ports[MAX_PATHS * 2];

	const char *gov_name;

	int ret, len, i, num_paths;
@@ -166,27 +147,9 @@ int devfreq_add_devbw(struct device *dev) 
	p->target = devbw_target;

	p->get_dev_status = devbw_get_dev_status;



	if (of_find_property(dev->of_node, PROP_TBL, &len)) {

		len /= sizeof(*data);

		data = devm_kzalloc(dev, len * sizeof(*data), GFP_KERNEL);

		if (!data)

			return -ENOMEM;



		p->freq_table = devm_kzalloc(dev,

					     len * sizeof(*p->freq_table),

					     GFP_KERNEL);

		if (!p->freq_table)

			return -ENOMEM;



		ret = of_property_read_u32_array(dev->of_node, PROP_TBL,

						 data, len);

	ret = dev_pm_opp_of_add_table(dev);

	if (ret)

			return ret;



		for (i = 0; i < len; i++)

			p->freq_table[i] = data[i];

		p->max_state = len;

	}

		dev_err(dev, "Couldn't parse OPP table:%d\n", ret);



	d->bus_client = msm_bus_scale_register_client(&d->bw_data);

	if (!d->bus_client) {