Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 009b1948 authored by Wan Ahmad Zainie's avatar Wan Ahmad Zainie Committed by Greg Kroah-Hartman
Browse files

usb: roles: intel_xhci: Fix Unbalanced pm_runtime_enable 



Add missing pm_runtime_disable() to remove(), in order to avoid
an Unbalanced pm_runtime_enable when the module is removed and
re-probed.

Error log:
root@intel-corei7-64:~# modprobe -r intel_xhci_usb_role_switch
root@intel-corei7-64:~# modprobe intel_xhci_usb_role_switch
intel_xhci_usb_sw intel_xhci_usb_sw: Unbalanced pm_runtime_enable!

Fixes: cb296846 (usb: roles: intel_xhci: Enable runtime PM)
Cc: <stable@vger.kernel.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarWan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f976d0e5

drivers/usb/roles/intel-xhci-usb-role-switch.c

+2 −0
Original line number Diff line number Diff line
@@ -161,6 +161,8 @@ static int intel_xhci_usb_remove(struct platform_device *pdev) 
{

	struct intel_xhci_usb_data *data = platform_get_drvdata(pdev);



	pm_runtime_disable(&pdev->dev);



	usb_role_switch_unregister(data->role_sw);

	return 0;

}