Commit 00777fac authored Mar 18, 2018 by Christophe JAILLET Committed by David S. Miller Mar 20, 2018

net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

If the optional regulator is deferred, we must release some resources.
They will be re-allocated when the probe function will be called again.

Fixes: 6eacf311 ("ethernet: arc: Add support for Rockchip SoC layer device tree bindings")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7fe4d6dc

drivers/net/ethernet/arc/emac_rockchip.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -169,8 +169,10 @@ static int emac_rockchip_probe(struct platform_device *pdev)
		/* Optional regulator for PHY */
		priv->regulator = devm_regulator_get_optional(dev, "phy");
		if (IS_ERR(priv->regulator)) {
		if (PTR_ERR(priv->regulator) == -EPROBE_DEFER)
		return -EPROBE_DEFER;
		if (PTR_ERR(priv->regulator) == -EPROBE_DEFER) {
		err = -EPROBE_DEFER;
		goto out_clk_disable;
		}
		dev_err(dev, "no regulator found\n");
		priv->regulator = NULL;
		}