Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00411b7b authored by Gabriel Somlo's avatar Gabriel Somlo Committed by Greg Kroah-Hartman
Browse files

firmware: fw_cfg register offsets on supported architectures only 



Refrain from defining default fw_cfg register offsets on
unsupported architectures -- throw an error instead. If
QEMU were to add fw_cfg support on additional architectures,
we should add them to the FW_CFG_SYSFS depends statement in
drivers/firmware/Kconfig, and provide default values for
register offsets in drivers/firmware/qemu_fw_cfg.c at that
time.

Suggested-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarGabriel Somlo <somlo@cmu.edu>
Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f55532a0

drivers/firmware/qemu_fw_cfg.c

+1 −3
Original line number Diff line number Diff line
@@ -109,9 +109,7 @@ static void fw_cfg_io_cleanup(void) 
#  define FW_CFG_CTRL_OFF 0x00

#  define FW_CFG_DATA_OFF 0x01

# else

#  warning "QEMU FW_CFG may not be available on this architecture!"

#  define FW_CFG_CTRL_OFF 0x00

#  define FW_CFG_DATA_OFF 0x01

#  error "QEMU FW_CFG not available on this architecture!"

# endif

#endif