Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 002a5abb authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: add error handling to toolaction_show 



Don't just drop the error from visorchannel_read on the floor, report it.

Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reviewed-by: default avatarReviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent deeeca6d

drivers/staging/unisys/visorbus/visorchipset.c

+8 −3
Original line number Diff line number Diff line
@@ -91,10 +91,15 @@ static ssize_t toolaction_show(struct device *dev, 
			       char *buf)

{

	u8 tool_action = 0;

	int err;



	visorchannel_read(chipset_dev->controlvm_channel,

	err = visorchannel_read(chipset_dev->controlvm_channel,

				offsetof(struct spar_controlvm_channel_protocol,

				   tool_action), &tool_action, sizeof(u8));

					 tool_action),

				&tool_action, sizeof(u8));

	if (err)

		return err;



	return sprintf(buf, "%u\n", tool_action);

}