Commit fff92c36 authored Sep 21, 2018 by Nathan Chancellor Committed by Greg Kroah-Hartman Nov 25, 2019

media: pxa_camera: Fix check for pdev->dev.of_node



[ Upstream commit 44d7f1a77d8c84f8e42789b5475b74ae0e6d4758 ]

Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

drivers/media/platform/pxa_camera.c:2400:17: warning: address of
'pdev->dev.of_node' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (&pdev->dev.of_node && !pcdev->pdata) {
             ~~~~~~~~~~^~~~~~~ ~~
1 warning generated.

Judging from the rest of the kernel, it seems like this was an error and
just the value of of_node should be checked rather than the address.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7e5212af

drivers/media/platform/pxa_camera.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2334,7 +2334,7 @@ static int pxa_camera_probe(struct platform_device *pdev)
		pcdev->res = res;

		pcdev->pdata = pdev->dev.platform_data;
		if (&pdev->dev.of_node && !pcdev->pdata) {
		if (pdev->dev.of_node && !pcdev->pdata) {
		err = pxa_camera_pdata_from_dt(&pdev->dev, pcdev, &pcdev->asd);
		} else {
		pcdev->platform_flags = pcdev->pdata->flags;