Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ffc32d52 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target: Make target_release_cmd_kref release on empty list



This patch changes target_release_cmd_kref() to make TFO->release_cmd()
call when list_empty(&se_cmd->se_cmd_list) is TRUE.  This is required
for TMR_ABORT_TASK operation where the referenced tag descriptor may
have already been pulled of the session command list.

Reported-by: default avatarRoland Dreier <roland@purestorage.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 86715569
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -4051,7 +4051,7 @@ static void target_release_cmd_kref(struct kref *kref)
	spin_lock_irqsave(&se_sess->sess_cmd_lock, flags);
	if (list_empty(&se_cmd->se_cmd_list)) {
		spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);
		WARN_ON(1);
		se_cmd->se_tfo->release_cmd(se_cmd);
		return;
	}
	if (se_sess->sess_tearing_down && se_cmd->cmd_wait_set) {