Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff8d97a8 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

ACM gadget: fix endianness in notifications 



commit cdd7928df0d2efaa3270d711963773a08a4cc8ab upstream.

The gadget code exports the bitfield for serial status changes
over the wire in its internal endianness. The fix is to convert
to little endian before sending it over the wire.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Tested-by: default avatar家瑋 <momo1208@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 381420a4

drivers/usb/gadget/function/f_acm.c

+3 −1
Original line number Diff line number Diff line
@@ -535,13 +535,15 @@ static int acm_notify_serial_state(struct f_acm *acm) 
{

	struct usb_composite_dev *cdev = acm->port.func.config->cdev;

	int			status;

	__le16			serial_state;



	spin_lock(&acm->lock);

	if (acm->notify_req) {

		dev_dbg(&cdev->gadget->dev, "acm ttyGS%d serial state %04x\n",

			acm->port_num, acm->serial_state);

		serial_state = cpu_to_le16(acm->serial_state);

		status = acm_cdc_notify(acm, USB_CDC_NOTIFY_SERIAL_STATE,

				0, &acm->serial_state, sizeof(acm->serial_state));

				0, &serial_state, sizeof(acm->serial_state));

	} else {

		acm->pending = true;

		status = 0;