Commit fef5b2ba authored Jul 04, 2016 by Amitoj Kaur Chawla Committed by Mark Brown Jul 04, 2016

ASoC: atmel-pdmic: Simplify use of devm_ioremap_resource



Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2d3c7e05

sound/soc/atmel/atmel-pdmic.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -624,11 +624,6 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
		}

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!res) {
		dev_err(dev, "no memory resource\n");
		return -ENXIO;
		}

		io_base = devm_ioremap_resource(dev, res);
		if (IS_ERR(io_base)) {
		ret = PTR_ERR(io_base);