Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fed1bf8d authored by Axel Lin's avatar Axel Lin Committed by Thierry Reding
Browse files

pwm: pca9685: Fix wrong argument to set MODE1_SLEEP bit 



Current code actually does not set MODE1_SLEEP bit because the new value for
bitmask (0x1) is wrong. To set MODE1_SLEEP bit, we should pass MODE1_SLEEP
as the new value for bitmask.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarSteffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 71077bc8

drivers/pwm/pwm-pca9685.c

+3 −2
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ static void pca9685_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) 


	if (--pca->active_cnt == 0)

		regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP,

				   0x1);

				   MODE1_SLEEP);

}



static const struct pwm_ops pca9685_pwm_ops = {
@@ -264,7 +264,8 @@ static int pca9685_pwm_remove(struct i2c_client *client) 
{

	struct pca9685 *pca = i2c_get_clientdata(client);



	regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP, 0x1);

	regmap_update_bits(pca->regmap, PCA9685_MODE1, MODE1_SLEEP,

			   MODE1_SLEEP);



	return pwmchip_remove(&pca->chip);

}