Commit fe0e2cf9 authored Aug 25, 2016 by oliver@schinagl.nl Committed by Thierry Reding Sep 08, 2016

pwm: lpc-18xx: use pwm_set_chip_data

The lpc-18xx driver currently manipulates the pwm_device struct directly
rather than using the pwm_set_chip_data() function. While the current
method may save a clock cycle or two, using the explicit function call
makes it more obvious that data is set to the local chip data pointer.

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Reviewed-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 42ddcf4f

drivers/pwm/pwm-lpc18xx-sct.c

+8 −4

Original line number	Diff line number	Diff line
		@@ -413,14 +413,18 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev)
		}

		for (i = 0; i < lpc18xx_pwm->chip.npwm; i++) {
		struct lpc18xx_pwm_data *data;

		pwm = &lpc18xx_pwm->chip.pwms[i];
		pwm->chip_data = devm_kzalloc(lpc18xx_pwm->dev,
		sizeof(struct lpc18xx_pwm_data),

		data = devm_kzalloc(lpc18xx_pwm->dev, sizeof(*data),
		GFP_KERNEL);
		if (!pwm->chip_data) {
		if (!data) {
		ret = -ENOMEM;
		goto remove_pwmchip;
		}

		pwm_set_chip_data(pwm, data);
		}

		platform_set_drvdata(pdev, lpc18xx_pwm);