Commit fdd8218d authored Oct 12, 2016 by Dan Carpenter Committed by Takashi Iwai Oct 12, 2016

ALSA: line6: fix a crash in line6_hwdep_write()



The error checking here is messed up so we could end up dereferencing
-EFAULT.

Fixes: a16039cb ('ALSA: line6: Add hwdep interface to access the POD control messages')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 30c07022

sound/usb/line6/driver.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep hwdep, const char __user data, long count,
		}

		data_copy = memdup_user(data, count);
		if (IS_ERR(ERR_PTR))
		return -ENOMEM;
		if (IS_ERR(data_copy))
		return PTR_ERR(data_copy);

		rv = line6_send_raw_message(line6, data_copy, count);