Commit fd9597d6 authored Jan 20, 2017 by Benjamin Tissoires Committed by Greg Kroah-Hartman Oct 08, 2017

HID: wacom: release the resources before leaving despite devm




[ Upstream commit 5b779fc52020ac6f5beea31c5eafc3d25cf70dc1 ]

In the general case, the resources are properly released by devm without
needing to do anything. However, when unplugging the wireless receiver,
the kernel segfaults from time to time while calling devres_release_all().

I think in that case the resources attempt to access hid_get_drvdata(hdev)
which has been set to null while leaving wacom_remove().

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent d621f970

drivers/hid/wacom_sys.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2433,6 +2433,8 @@ static void wacom_remove(struct hid_device *hdev)
		if (hdev->bus == BUS_BLUETOOTH)
		device_remove_file(&hdev->dev, &dev_attr_speed);

		wacom_release_resources(wacom);

		hid_set_drvdata(hdev, NULL);
		}