Commit fd45c15f authored Jan 20, 2012 by Namhyung Kim Committed by Ingo Molnar Jan 21, 2012

perf: Don't call release_callchain_buffers() if allocation fails



When alloc_callchain_buffers() fails, it frees all of
entries before return. In addition, calling the
release_callchain_buffers() will cause a NULL pointer
dereference since callchain_cpu_entries is not set.

Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Link: http://lkml.kernel.org/r/1327021966-27688-1-git-send-email-namhyung.kim@lge.com


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent dcd6c922

kernel/events/callchain.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -115,8 +115,6 @@ int get_callchain_buffers(void)
		}

		err = alloc_callchain_buffers();
		if (err)
		release_callchain_buffers();
		exit:
		mutex_unlock(&callchain_mutex);