Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd05d7b1 authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

net: dsa: fix fixed-link-phy device leaks 



Make sure to drop the reference taken by of_phy_find_device() when
registering and deregistering the fixed-link PHY-device.

Fixes: 39b0c705 ("net: dsa: Allow configuration of CPU & DSA port
speeds/duplex")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c9bd2823

net/dsa/dsa.c

+4 −1
Original line number Diff line number Diff line
@@ -233,6 +233,8 @@ int dsa_cpu_dsa_setup(struct dsa_switch *ds, struct device *dev, 
		genphy_read_status(phydev);

		if (ds->ops->adjust_link)

			ds->ops->adjust_link(ds, port, phydev);



		put_device(&phydev->mdio.dev);

	}



	return 0;
@@ -509,8 +511,9 @@ void dsa_cpu_dsa_destroy(struct device_node *port_dn) 
	if (of_phy_is_fixed_link(port_dn)) {

		phydev = of_phy_find_device(port_dn);

		if (phydev) {

			phy_device_free(phydev);

			fixed_phy_unregister(phydev);

			put_device(&phydev->mdio.dev);

			phy_device_free(phydev);

		}

	}

}