Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcffd0d8 authored by Meelis Roos's avatar Meelis Roos Committed by David S. Miller
Browse files

fore200: fix oops on failed firmware load 



Fore 200 ATM driver fails to handle request_firmware failures and oopses 
when no firmware file was found. Fix it by checking for the right return 
values and propaganting the return value up.

Signed-off-by: default avatarMeelis Roos <mroos@linux.ee>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e672f7db

drivers/atm/fore200e.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -2519,8 +2519,8 @@ fore200e_load_and_start_fw(struct fore200e* fore200e) 
	return err;

	return err;





    sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);

    sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);

    if (request_firmware(&firmware, buf, device) == 1) {

    if ((err = request_firmware(&firmware, buf, device)) < 0) {

	printk(FORE200E "missing %s firmware image\n", fore200e->bus->model_name);

	printk(FORE200E "problem loading firmware image %s\n", fore200e->bus->model_name);

	return err;

	return err;

    }

    }