Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcfb7ce3 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Andi Kleen
Browse files

PNP: improve resource assignment debug 



When we fail to assign an I/O or MEM resource, include the min/max
in the debug output to help match it with the options.

Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Acked-by: default avatarRene Herman <rene.herman@gmail.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 169aaffe

drivers/pnp/manager.c

+8 −2
Original line number Diff line number Diff line
@@ -47,7 +47,10 @@ static int pnp_assign_port(struct pnp_dev *dev, struct pnp_port *rule, int idx) 
		res->start += rule->align;

		res->end = res->start + rule->size - 1;

		if (res->start > rule->max || !rule->align) {

			dev_dbg(&dev->dev, "  couldn't assign io %d\n", idx);

			dev_dbg(&dev->dev, "  couldn't assign io %d "

				"(min %#llx max %#llx)\n", idx,

				(unsigned long long) rule->min,

				(unsigned long long) rule->max);

			return 0;

		}

	}
@@ -96,7 +99,10 @@ static int pnp_assign_mem(struct pnp_dev *dev, struct pnp_mem *rule, int idx) 
		res->start += rule->align;

		res->end = res->start + rule->size - 1;

		if (res->start > rule->max || !rule->align) {

			dev_dbg(&dev->dev, "  couldn't assign mem %d\n", idx);

			dev_dbg(&dev->dev, "  couldn't assign mem %d "

				"(min %#llx max %#llx)\n", idx,

				(unsigned long long) rule->min,

				(unsigned long long) rule->max);

			return 0;

		}

	}