Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fcbefc3b authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Martin K. Petersen
Browse files

scsi: ufs: remove unnecessary goto label 



When buff_ascii kmalloc failed, there is no need to call kfree, it
should return -ENOMEM directly, this patch fixes it.

Signed-off-by: default avatarTiezhu Yang <kernelpatch@126.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3fb134cb

drivers/scsi/ufs/ufshcd.c

+1 −2
Original line number Diff line number Diff line
@@ -2137,7 +2137,7 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf, 
		buff_ascii = kmalloc(ascii_len, GFP_KERNEL);

		if (!buff_ascii) {

			err = -ENOMEM;

			goto out_free_buff;

			goto out;

		}



		/*
@@ -2156,7 +2156,6 @@ int ufshcd_read_string_desc(struct ufs_hba *hba, int desc_index, u8 *buf, 
				size - QUERY_DESC_HDR_SIZE);

		memcpy(buf + QUERY_DESC_HDR_SIZE, buff_ascii, ascii_len);

		buf[QUERY_DESC_LENGTH_OFFSET] = ascii_len + QUERY_DESC_HDR_SIZE;

out_free_buff:

		kfree(buff_ascii);

	}

out: