Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fbd5896b authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Input: raydium_i2c_ts - fix error codes in raydium_i2c_boot_trigger() 



[ Upstream commit 32cf3a610c35cb21e3157f4bbf29d89960e30a36 ]

These functions are supposed to return negative error codes but instead
it returns true on failure and false on success.  The error codes are
eventually propagated back to user space.

Fixes: 48a2b783 ("Input: add Raydium I2C touchscreen driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200303101306.4potflz7na2nn3od@kili.mountain


Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9ff4173c

drivers/input/touchscreen/raydium_i2c_ts.c

+4 −4
Original line number Diff line number Diff line
@@ -441,7 +441,7 @@ static int raydium_i2c_write_object(struct i2c_client *client, 
	return 0;

}



static bool raydium_i2c_boot_trigger(struct i2c_client *client)

static int raydium_i2c_boot_trigger(struct i2c_client *client)

{

	static const u8 cmd[7][6] = {

		{ 0x08, 0x0C, 0x09, 0x00, 0x50, 0xD7 },
@@ -466,10 +466,10 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client) 
		}

	}



	return false;

	return 0;

}



static bool raydium_i2c_fw_trigger(struct i2c_client *client)

static int raydium_i2c_fw_trigger(struct i2c_client *client)

{

	static const u8 cmd[5][11] = {

		{ 0, 0x09, 0x71, 0x0C, 0x09, 0x00, 0x50, 0xD7, 0, 0, 0 },
@@ -492,7 +492,7 @@ static bool raydium_i2c_fw_trigger(struct i2c_client *client) 
		}

	}



	return false;

	return 0;

}



static int raydium_i2c_check_path(struct i2c_client *client)