Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fba12966 authored by Kamal Heib's avatar Kamal Heib Committed by David S. Miller
Browse files

net/mlx4_core: Fix to clean devlink resources 



This patch cleans devlink resources by calling devlink_port_unregister()
to avoid the following issues:

- Kernel panic when triggering reset flow.
- Memory leak due to unfreed resources in mlx4_init_port_info().

Fixes: 09d4d087 ("mlx4: Implement devlink interface")
Signed-off-by: default avatarKamal Heib <kamalh@mellanox.com>
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7932aa1e

drivers/net/ethernet/mellanox/mlx4/main.c

+3 −0
Original line number Diff line number Diff line
@@ -2970,6 +2970,7 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port) 
		mlx4_err(dev, "Failed to create mtu file for port %d\n", port);

		device_remove_file(&info->dev->persist->pdev->dev,

				   &info->port_attr);

		devlink_port_unregister(&info->devlink_port);

		info->port = -1;

	}
@@ -2984,6 +2985,8 @@ static void mlx4_cleanup_port_info(struct mlx4_port_info *info) 
	device_remove_file(&info->dev->persist->pdev->dev, &info->port_attr);

	device_remove_file(&info->dev->persist->pdev->dev,

			   &info->port_mtu_attr);

	devlink_port_unregister(&info->devlink_port);



#ifdef CONFIG_RFS_ACCEL

	free_irq_cpu_rmap(info->rmap);

	info->rmap = NULL;