Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fba023f8 authored by Roopa Prabhu's avatar Roopa Prabhu Committed by Greg Kroah-Hartman
Browse files

net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags 

commit 56a49d7048703f5ffdb84d3a0ee034108fba6850 upstream.

This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071



Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of
dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED.
Fix it by indicating flag changes explicitly to __dev_notify_flags.

Fixes: 5025f7f7d506 ("rtnetlink: add rtnl_link_state check in rtnl_configure_link")
Reported-By: default avatarLiam mcbirnie <liam.mcbirnie@boeing.com>
Signed-off-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6e3885a3

net/core/rtnetlink.c

+1 −1
Original line number Diff line number Diff line
@@ -2361,7 +2361,7 @@ int rtnl_configure_link(struct net_device *dev, const struct ifinfomsg *ifm) 
	}



	if (dev->rtnl_link_state == RTNL_LINK_INITIALIZED) {

		__dev_notify_flags(dev, old_flags, 0U);

		__dev_notify_flags(dev, old_flags, (old_flags ^ dev->flags));

	} else {

		dev->rtnl_link_state = RTNL_LINK_INITIALIZED;

		__dev_notify_flags(dev, old_flags, ~0U);