Commit fb8a0ef0 authored Nov 17, 2020 by Yang Yingliang Committed by Greg Kroah-Hartman Dec 29, 2020

speakup: fix uninitialized flush_lock



[ Upstream commit d1b928ee1cfa965a3327bbaa59bfa005d97fa0fe ]

The flush_lock is uninitialized, use DEFINE_SPINLOCK
to define and initialize flush_lock.

Fixes: c6e3fd22 ("Staging: add speakup to the staging directory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20201117012229.3395186-1-yangyingliang@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a072896a

drivers/staging/speakup/speakup_dectlk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -47,7 +47,7 @@ static unsigned char get_index(void);
		static int in_escape;
		static int is_flushing;

		static spinlock_t flush_lock;
		static DEFINE_SPINLOCK(flush_lock);
		static DECLARE_WAIT_QUEUE_HEAD(flush);

		static struct var_t vars[] = {