Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb841d67 authored by Jesper Juhl's avatar Jesper Juhl Committed by Greg Kroah-Hartman
Browse files

staging: vt6656: don't leak 'param' in vt6656_hostap_ioctl() when returning -EOPNOTSUPP 



Don't return -EOPNOTSUPP directly in switch case's since it'll leak
the memory allocated to 'param' when that variable goes out of scope
without having been assigned to anything.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b95dd03d

drivers/staging/vt6656/hostap.c

+6 −6
Original line number Diff line number Diff line
@@ -732,8 +732,8 @@ int vt6656_hostap_ioctl(PSDevice pDevice, struct iw_point *p) 
		break;

	case VIAWGET_HOSTAPD_SET_ASSOC_AP_ADDR:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_SET_ASSOC_AP_ADDR \n");

		return -EOPNOTSUPP;

		break;

		ret = -EOPNOTSUPP;

		goto out;

	case VIAWGET_HOSTAPD_FLUSH:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_FLUSH \n");

        spin_lock_irq(&pDevice->lock);
@@ -777,13 +777,13 @@ int vt6656_hostap_ioctl(PSDevice pDevice, struct iw_point *p) 


	case VIAWGET_HOSTAPD_STA_CLEAR_STATS:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "VIAWGET_HOSTAPD_STA_CLEAR_STATS \n");

	    return -EOPNOTSUPP;



	    ret = -EOPNOTSUPP;

	    goto out;

	default:

	    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "vt6656_hostap_ioctl: unknown cmd=%d\n",

		       (int)param->cmd);

		return -EOPNOTSUPP;

		break;

		ret = -EOPNOTSUPP;

		goto out;

	}