Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faf1e785 authored by françois romieu's avatar françois romieu Committed by David S. Miller
Browse files

r8169: honor jumbo settings when chipset is requested to start. 



Some hardware start settings implicitely assume an usual 1500 bytes mtu
that can't be guaranteed because changes of mtu may be requested both
before and after the hardware is started.

Reported-by: default avatarTomi Orava <tomimo@ncircle.nullnet.fi>
Signed-off-by: default avatarFrancois Romieu <romieu@fr.zoreil.com>
Cc: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 79ffef1f

drivers/net/ethernet/realtek/r8169.c

+18 −9
Original line number Diff line number Diff line
@@ -4765,8 +4765,10 @@ static void rtl_hw_start_8168bb(struct rtl8169_private *tp) 


	RTL_W16(CPlusCmd, RTL_R16(CPlusCmd) & ~R8168_CPCMD_QUIRK_MASK);



	rtl_tx_performance_tweak(pdev,

		(0x5 << MAX_READ_REQUEST_SHIFT) | PCI_EXP_DEVCTL_NOSNOOP_EN);

	if (tp->dev->mtu <= ETH_DATA_LEN) {

		rtl_tx_performance_tweak(pdev, (0x5 << MAX_READ_REQUEST_SHIFT) |

					 PCI_EXP_DEVCTL_NOSNOOP_EN);

	}

}



static void rtl_hw_start_8168bef(struct rtl8169_private *tp)
@@ -4789,6 +4791,7 @@ static void __rtl_hw_start_8168cp(struct rtl8169_private *tp) 


	RTL_W8(Config3, RTL_R8(Config3) & ~Beacon_en);



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	rtl_disable_clock_request(pdev);
@@ -4822,6 +4825,7 @@ static void rtl_hw_start_8168cp_2(struct rtl8169_private *tp) 


	RTL_W8(Config3, RTL_R8(Config3) & ~Beacon_en);



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	RTL_W16(CPlusCmd, RTL_R16(CPlusCmd) & ~R8168_CPCMD_QUIRK_MASK);
@@ -4841,6 +4845,7 @@ static void rtl_hw_start_8168cp_3(struct rtl8169_private *tp) 


	RTL_W8(MaxTxPacketSize, TxPacketMax);



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	RTL_W16(CPlusCmd, RTL_R16(CPlusCmd) & ~R8168_CPCMD_QUIRK_MASK);
@@ -4901,6 +4906,7 @@ static void rtl_hw_start_8168d(struct rtl8169_private *tp) 


	RTL_W8(MaxTxPacketSize, TxPacketMax);



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	RTL_W16(CPlusCmd, RTL_R16(CPlusCmd) & ~R8168_CPCMD_QUIRK_MASK);
@@ -4913,6 +4919,7 @@ static void rtl_hw_start_8168dp(struct rtl8169_private *tp) 


	rtl_csi_access_enable_1(tp);



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	RTL_W8(MaxTxPacketSize, TxPacketMax);
@@ -4972,6 +4979,7 @@ static void rtl_hw_start_8168e_1(struct rtl8169_private *tp) 


	rtl_ephy_init(tp, e_info_8168e_1, ARRAY_SIZE(e_info_8168e_1));



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	RTL_W8(MaxTxPacketSize, TxPacketMax);
@@ -4998,6 +5006,7 @@ static void rtl_hw_start_8168e_2(struct rtl8169_private *tp) 


	rtl_ephy_init(tp, e_info_8168e_2, ARRAY_SIZE(e_info_8168e_2));



	if (tp->dev->mtu <= ETH_DATA_LEN)

		rtl_tx_performance_tweak(pdev, 0x5 << MAX_READ_REQUEST_SHIFT);



	rtl_eri_write(tp, 0xc0, ERIAR_MASK_0011, 0x0000, ERIAR_EXGMAC);