Commit fabc16fe authored Jun 02, 2016 by Takashi Iwai

ALSA: hda - Turn off loopback mixing as default



So far, we enabled the loopback mixing control as default, as this
behavior made somewhat compatible with the earlier HD-audio drivers
for Realtek & co.  However, it's getting annoying as we've got more
and more bug reports about the noise coming from the loopback route.
Since the loopback mixing is used fairly rarely and often harmful
(e.g. using PA), let's get rid of the default turn-on lines.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 1524c719

sound/pci/hda/hda_generic.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2492,10 +2492,6 @@ static int create_loopback_mixing_ctl(struct hda_codec *codec)
		if (!snd_hda_gen_add_kctl(spec, NULL, &loopback_mixing_enum))
		return -ENOMEM;
		spec->have_aamix_ctl = 1;
		/* if no explicit aamix path is present (e.g. for Realtek codecs),
		* enable aamix as default -- just for compatibility
		*/
		spec->aamix_mode = !has_aamix_out_paths(spec);
		return 0;
		}