Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit faa98f7e authored by Laxman Dewangan's avatar Laxman Dewangan Committed by Mark Brown
Browse files

spi: tegra: slink: do not prepare dma transfer with DMA_CTRL_ACK flag 



Spi starts transfer using dma with DMA_CTRL_ACK which is not require
becasue spi driver does not use completed dma_desc after transfer
done and so it does not ack the dma descriptor. Removing the
DMA_CTRL_ACK flag to avoid memory leak in dma driver.

Signed-off-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 8179bb26

drivers/spi/spi-tegra20-slink.c

+2 −2
Original line number Diff line number Diff line
@@ -467,7 +467,7 @@ static int tegra_slink_start_tx_dma(struct tegra_slink_data *tspi, int len) 
	INIT_COMPLETION(tspi->tx_dma_complete);

	tspi->tx_dma_desc = dmaengine_prep_slave_single(tspi->tx_dma_chan,

				tspi->tx_dma_phys, len, DMA_MEM_TO_DEV,

				DMA_PREP_INTERRUPT |  DMA_CTRL_ACK);

				DMA_PREP_INTERRUPT);

	if (!tspi->tx_dma_desc) {

		dev_err(tspi->dev, "Not able to get desc for Tx\n");

		return -EIO;
@@ -486,7 +486,7 @@ static int tegra_slink_start_rx_dma(struct tegra_slink_data *tspi, int len) 
	INIT_COMPLETION(tspi->rx_dma_complete);

	tspi->rx_dma_desc = dmaengine_prep_slave_single(tspi->rx_dma_chan,

				tspi->rx_dma_phys, len, DMA_DEV_TO_MEM,

				DMA_PREP_INTERRUPT |  DMA_CTRL_ACK);

				DMA_PREP_INTERRUPT);

	if (!tspi->rx_dma_desc) {

		dev_err(tspi->dev, "Not able to get desc for Rx\n");

		return -EIO;