Commit fa9e6fc7 authored Aug 10, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Sep 26, 2021

thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()



commit 02d438f62c05f0d055ceeedf12a2f8796b258c08 upstream.

This error path return success but it should propagate the negative
error code from devm_clk_get().

Fixes: 6c247393 ("thermal: exynos: Add TMU support for Exynos7 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210810084413.GA23810@kili


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e5261b31

drivers/thermal/samsung/exynos_tmu.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1372,6 +1372,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
	data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");		data->sclk = devm_clk_get(&pdev->dev, "tmu_sclk");
	if (IS_ERR(data->sclk)) {		if (IS_ERR(data->sclk)) {
	dev_err(&pdev->dev, "Failed to get sclk\n");		dev_err(&pdev->dev, "Failed to get sclk\n");
			ret = PTR_ERR(data->sclk);
	goto err_clk;		goto err_clk;
	} else {		} else {
	ret = clk_prepare_enable(data->sclk);		ret = clk_prepare_enable(data->sclk);