Commit fa60cf7f authored Feb 04, 2006 by Herbert Xu Committed by David S. Miller Feb 04, 2006

[ICMP]: Fix extra dst release when ip_options_echo fails



When two ip_route_output_key lookups in icmp_send were combined I
forgot to change the error path for ip_options_echo to not drop the
dst reference since it now sits before the dst lookup.  To fix it we
simply jump past the ip_rt_put call.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5b7b644c

net/ipv4/icmp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -524,7 +524,7 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, u32 info)
		iph->tos;

		if (ip_options_echo(&icmp_param.replyopts, skb_in))
		goto ende;
		goto out_unlock;


		/*